<html>
<head><meta charset="utf-8"><title>Rename LintSource · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html">Rename LintSource</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220636418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636418">(Dec 21 2020 at 22:09)</a>:</h4>
<p>Hi all! </p>
<p>I was reading through the source for rustc_middle to help with documentation. I had a naming thought. I think a nicer name for rustc_middle::lint::LintSource (<a href="https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/lint/enum.LintSource.html">https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/lint/enum.LintSource.html</a>) might be <code>LintLevelSource</code>.<br>
How might folks feel about this? How likely is such a simple find/replace to cause problems?</p>
<p>(I was a bit nervous to open an issue, as this is the first actual code change I'm suggesting. Hope it's alright to create a Zulip topic for this!)</p>



<a name="220636457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636457">(Dec 21 2020 at 22:09)</a>:</h4>
<p>Seems like a good idea to me.</p>



<a name="220636478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636478">(Dec 21 2020 at 22:10)</a>:</h4>
<blockquote>
<p>How might folks feel about this? How likely is such a simple find/replace to cause problems?</p>
</blockquote>
<p>CI should catch any issues, since it's just a name change.</p>



<a name="220636526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636526">(Dec 21 2020 at 22:10)</a>:</h4>
<p><span aria-label="grinning face with smiling eyes" class="emoji emoji-1f601" role="img" title="grinning face with smiling eyes">:grinning_face_with_smiling_eyes:</span></p>



<a name="220636545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636545">(Dec 21 2020 at 22:10)</a>:</h4>
<blockquote>
<p>(I was a bit nervous to open an issue, as this is the first actual code change I'm suggesting. Hope it's alright to create a Zulip topic for this!)</p>
</blockquote>
<p>Definitely okay to make a Zulip topic!</p>



<a name="220636556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636556">(Dec 21 2020 at 22:10)</a>:</h4>
<p>Wow! Thanks for quick response y'all!</p>



<a name="220636563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636563">(Dec 21 2020 at 22:10)</a>:</h4>
<p>Hi <span class="user-mention" data-user-id="316352">@pierwill</span>, I'm pretty sure you won't bother anyone by opening a Zulip topic nor by opening an issue/PR</p>



<a name="220636599"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636599" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636599">(Dec 21 2020 at 22:10)</a>:</h4>
<p>I'm excited to submit my first code to the compiler :)</p>



<a name="220636610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220636610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220636610">(Dec 21 2020 at 22:10)</a>:</h4>
<p>Au contraire :D</p>



<a name="220637033"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220637033" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220637033">(Dec 21 2020 at 22:14)</a>:</h4>
<p>Merci :)</p>



<a name="220637697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220637697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220637697">(Dec 21 2020 at 22:22)</a>:</h4>
<p>Should be able to check this with x.y check, yes?</p>



<a name="220637721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220637721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220637721">(Dec 21 2020 at 22:22)</a>:</h4>
<p>Yes, for refractoring changes <code>x.py check</code> is enough <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="220637732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220637732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220637732">(Dec 21 2020 at 22:22)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="220638168"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220638168" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220638168">(Dec 21 2020 at 22:27)</a>:</h4>
<p>Ah yes, unexpected things to update!</p>
<div class="codehilite"><pre><span></span><code>error[E0432]: unresolved import `rustc_middle::lint::LintSource`
  --&gt; src/librustdoc/passes/doc_test_lints.rs:12:5
   |
12 | use rustc_middle::lint::LintSource;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `LintSource` in `lint`
</code></pre></div>



<a name="220638658"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220638658" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220638658">(Dec 21 2020 at 22:32)</a>:</h4>
<p>this is the main reason rust-lang/rust needs a special tool and not 'just cargo'</p>



<a name="220638673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220638673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220638673">(Dec 21 2020 at 22:32)</a>:</h4>
<p>it's several different projects under the same umbrella</p>



<a name="220638678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220638678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220638678">(Dec 21 2020 at 22:32)</a>:</h4>
<p>that + bootstrapping</p>



<a name="220638878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220638878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220638878">(Dec 21 2020 at 22:34)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/80274">https://github.com/rust-lang/rust/pull/80274</a> <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="220639759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220639759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220639759">(Dec 21 2020 at 22:45)</a>:</h4>
<p>Then following the rabbit hole, realized more docs would be nice here:  <a href="https://github.com/rust-lang/rust/pull/80274/commits/2df886c1e378a73c3b64337e4cf6881274c6b64a">https://github.com/rust-lang/rust/pull/80274/commits/2df886c1e378a73c3b64337e4cf6881274c6b64a</a></p>



<a name="220639858"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220639858" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220639858">(Dec 21 2020 at 22:46)</a>:</h4>
<p>with all your documentation work, could I convince you to work on rustdoc? ;) <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="220639894"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220639894" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220639894">(Dec 21 2020 at 22:47)</a>:</h4>
<p>I'm sure I'll get over there someday! Just fascinated with the compiler rn</p>



<a name="220640346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220640346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220640346">(Dec 21 2020 at 22:52)</a>:</h4>
<p>Semi-related: are PR adding docs to functions/types/etc in the compiler accepted ? I was using the nightly-rustc docs and they are so empty</p>



<a name="220640365"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220640365" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220640365">(Dec 21 2020 at 22:52)</a>:</h4>
<p>I wanted to write docs for those poor poor functions</p>



<a name="220640380"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220640380" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220640380">(Dec 21 2020 at 22:52)</a>:</h4>
<p>I don't know why they wouldn't be accepted</p>



<a name="220640433"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220640433" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220640433">(Dec 21 2020 at 22:53)</a>:</h4>
<p>I guess the main issue you might run into is the "lack" of reviewers right now</p>



<a name="220640434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220640434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220640434">(Dec 21 2020 at 22:53)</a>:</h4>
<p>Well, it’s purely internal and may change very often, which would mean more work for the people updating them since they have to then update the docs</p>



<a name="220640468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220640468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220640468">(Dec 21 2020 at 22:53)</a>:</h4>
<p>I'm always a fan of more docs. Gotta read code to write it!</p>



<a name="220640480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220640480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220640480">(Dec 21 2020 at 22:53)</a>:</h4>
<blockquote>
<p>I guess the main issue you might run into is the "lack" of reviewers right now</p>
</blockquote>
<p>Oh yeah I intend to wait for January, vacation time right now ^^</p>



<a name="220640887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220640887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220640887">(Dec 21 2020 at 22:59)</a>:</h4>
<p>Well as a hobbyist, to me vacation time is "more free time" time :)</p>



<a name="220641068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220641068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220641068">(Dec 21 2020 at 23:01)</a>:</h4>
<p>I ran x.py fmt to fix a line length issue. What's the best thing to do now? Push a new commit for the formatting?</p>



<a name="220641143"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220641143" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220641143">(Dec 21 2020 at 23:02)</a>:</h4>
<p>normally I rewrite history with <code>git commit --amend</code></p>



<a name="220641183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220641183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220641183">(Dec 21 2020 at 23:02)</a>:</h4>
<p>And then force push?</p>



<a name="220641187"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220641187" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220641187">(Dec 21 2020 at 23:02)</a>:</h4>
<p>k</p>



<a name="220647349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220647349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220647349">(Dec 22 2020 at 00:36)</a>:</h4>
<p>Does this need reapproval after a force push?<br>
<a href="https://github.com/rust-lang/rust/pull/80274">https://github.com/rust-lang/rust/pull/80274</a></p>



<a name="220647721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220647721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220647721">(Dec 22 2020 at 00:42)</a>:</h4>
<p>Yes, PRs always need re-approval after any kind of push.</p>



<a name="220647751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220647751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220647751">(Dec 22 2020 at 00:43)</a>:</h4>
<p>Cool, cool. Do authors <code>r+ </code> the original reviewer, then?</p>



<a name="220647844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220647844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220647844">(Dec 22 2020 at 00:44)</a>:</h4>
<p>You don't have r+ rights and neither do I, so we need someone else to do it.</p>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> Might I interest you in an <code>r=petrochenkov</code>? ;)</p>



<a name="220647977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220647977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220647977">(Dec 22 2020 at 00:46)</a>:</h4>
<p>ah yes i meant r? i think</p>



<a name="220648116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220648116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220648116">(Dec 22 2020 at 00:48)</a>:</h4>
<p>Hmm, not sure what you mean. <code>r?</code> assigns someone, but petrochenkov is already assigned.</p>



<a name="220648140"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220648140" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220648140">(Dec 22 2020 at 00:49)</a>:</h4>
<p>Ah sorry, I thought it requested a review...</p>



<a name="220648272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220648272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220648272">(Dec 22 2020 at 00:51)</a>:</h4>
<p>Usually you can just ping your reviewer if you want to request a review. But usually you shouldn't do it unless it's been a while since people are busy.</p>



<a name="220648375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220648375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pierwill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220648375">(Dec 22 2020 at 00:53)</a>:</h4>
<p>I figured. I'm just excited <span aria-label="innocent" class="emoji emoji-1f607" role="img" title="innocent">:innocent:</span></p>



<a name="220648387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220648387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220648387">(Dec 22 2020 at 00:53)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> is usually pretty responsive about things like this, so he'll probably get to it soon. Either way people usually will come around and re-approve pretty quickly.</p>



<a name="220648449"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220648449" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220648449">(Dec 22 2020 at 00:54)</a>:</h4>
<p>Just to set expectations, once something is r+'ed it can take up to a day or two to actually get merged.</p>



<a name="220648463"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220648463" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220648463">(Dec 22 2020 at 00:54)</a>:</h4>
<p>You can see the queue at <a href="http://bors.rust-lang.org/queue/rust">bors.rust-lang.org/queue/rust</a>.</p>



<a name="220648485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220648485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220648485">(Dec 22 2020 at 00:54)</a>:</h4>
<p>Ah, I forgot that you've contributed docs already so you know.</p>



<a name="220693837"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220693837" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220693837">(Dec 22 2020 at 14:25)</a>:</h4>
<p><span class="user-mention silent" data-user-id="307289">Poliorcetics</span> <a href="#narrow/stream/131828-t-compiler/topic/Rename.20LintSource/near/220640346">said</a>:</p>
<blockquote>
<p>Semi-related: are PR adding docs to functions/types/etc in the compiler accepted ? I was using the nightly-rustc docs and they are so empty</p>
</blockquote>
<p>if someone wants to make the inline code blocks intra-doc links that would be super helpful I think. I found a bunch with <code> rg '///.*[^\[]`.*`' </code>.</p>



<a name="220701660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220701660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220701660">(Dec 22 2020 at 15:35)</a>:</h4>
<p>Inline code blocks ?</p>



<a name="220701692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220701692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220701692">(Dec 22 2020 at 15:35)</a>:</h4>
<p>Something like <code> `foo` </code>.</p>



<a name="220701709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220701709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220701709">(Dec 22 2020 at 15:35)</a>:</h4>
<p>Ah thanks ^^</p>



<a name="220701719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220701719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Poliorcetics <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220701719">(Dec 22 2020 at 15:35)</a>:</h4>
<p>I wasn’t reading the regex right</p>



<a name="220703400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Rename%20LintSource/near/220703400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Rename.20LintSource.html#220703400">(Dec 22 2020 at 15:51)</a>:</h4>
<p>example pr: <a href="https://github.com/rust-lang/rust/pull/80297">https://github.com/rust-lang/rust/pull/80297</a></p>
<p>(happy for anyone here to approve that)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>